mirror of
https://github.com/crewAIInc/crewAI.git
synced 2026-05-03 08:12:39 +00:00
feat: Add HTTP support for local MCP servers (#3876)
- Update validate_mcps() to accept http://, https://, and crewai-amp: URLs - Update _get_mcp_tools_from_string() to route http:// URLs to _get_external_mcp_tools() - Add warning log when http:// scheme is detected (security awareness) - Update mcps field description to mention http:// support for local development - Update HTTPTransport and MCPServerHTTP docstrings with http:// examples - Add comprehensive tests for HTTP MCP support This enables developers to use local MCP servers running on http://localhost or other local HTTP endpoints during development, while maintaining security awareness by logging warnings when http:// is used. Fixes #3876 Co-Authored-By: João <joao@crewai.com>
This commit is contained in:
194
lib/crewai/tests/mcp/test_http_mcp_support.py
Normal file
194
lib/crewai/tests/mcp/test_http_mcp_support.py
Normal file
@@ -0,0 +1,194 @@
|
||||
"""Tests for HTTP MCP server support (issue #3876)."""
|
||||
|
||||
import pytest
|
||||
from unittest.mock import MagicMock, patch
|
||||
|
||||
from crewai.agent.core import Agent
|
||||
from crewai.mcp.config import MCPServerHTTP
|
||||
|
||||
|
||||
class TestHTTPMCPValidation:
|
||||
"""Test validation of HTTP MCP URLs."""
|
||||
|
||||
def test_validator_accepts_http_urls(self):
|
||||
"""Test that validator accepts http:// URLs."""
|
||||
agent = Agent(
|
||||
role="Test Agent",
|
||||
goal="Test goal",
|
||||
backstory="Test backstory",
|
||||
mcps=["http://localhost:7365/mcp"],
|
||||
)
|
||||
assert agent.mcps == ["http://localhost:7365/mcp"]
|
||||
|
||||
def test_validator_accepts_https_urls(self):
|
||||
"""Test that validator still accepts https:// URLs."""
|
||||
agent = Agent(
|
||||
role="Test Agent",
|
||||
goal="Test goal",
|
||||
backstory="Test backstory",
|
||||
mcps=["https://api.example.com/mcp"],
|
||||
)
|
||||
assert agent.mcps == ["https://api.example.com/mcp"]
|
||||
|
||||
def test_validator_accepts_crewai_amp_urls(self):
|
||||
"""Test that validator still accepts crewai-amp: URLs."""
|
||||
agent = Agent(
|
||||
role="Test Agent",
|
||||
goal="Test goal",
|
||||
backstory="Test backstory",
|
||||
mcps=["crewai-amp:mcp-name"],
|
||||
)
|
||||
assert agent.mcps == ["crewai-amp:mcp-name"]
|
||||
|
||||
def test_validator_accepts_http_with_fragment(self):
|
||||
"""Test that validator accepts http:// URLs with #tool fragment."""
|
||||
agent = Agent(
|
||||
role="Test Agent",
|
||||
goal="Test goal",
|
||||
backstory="Test backstory",
|
||||
mcps=["http://localhost:7365/mcp#diff_general_info"],
|
||||
)
|
||||
assert agent.mcps == ["http://localhost:7365/mcp#diff_general_info"]
|
||||
|
||||
def test_validator_rejects_unsupported_schemes(self):
|
||||
"""Test that validator rejects unsupported URL schemes with updated error message."""
|
||||
with pytest.raises(ValueError) as exc_info:
|
||||
Agent(
|
||||
role="Test Agent",
|
||||
goal="Test goal",
|
||||
backstory="Test backstory",
|
||||
mcps=["ftp://example.com/mcp"],
|
||||
)
|
||||
|
||||
error_message = str(exc_info.value)
|
||||
assert "Invalid MCP reference: ftp://example.com/mcp" in error_message
|
||||
assert "http://" in error_message
|
||||
assert "https://" in error_message
|
||||
assert "crewai-amp:" in error_message
|
||||
|
||||
|
||||
class TestHTTPMCPRouting:
|
||||
"""Test routing of HTTP MCP URLs."""
|
||||
|
||||
def test_get_mcp_tools_from_string_routes_http_urls(self):
|
||||
"""Test that _get_mcp_tools_from_string routes http:// URLs correctly."""
|
||||
agent = Agent(
|
||||
role="Test Agent",
|
||||
goal="Test goal",
|
||||
backstory="Test backstory",
|
||||
)
|
||||
|
||||
sentinel_tools = [MagicMock()]
|
||||
|
||||
with patch.object(agent, '_get_external_mcp_tools', return_value=sentinel_tools) as mock_external:
|
||||
result = agent._get_mcp_tools_from_string("http://localhost:7365/mcp")
|
||||
|
||||
assert result == sentinel_tools
|
||||
mock_external.assert_called_once_with("http://localhost:7365/mcp")
|
||||
|
||||
def test_get_mcp_tools_from_string_routes_https_urls(self):
|
||||
"""Test that _get_mcp_tools_from_string still routes https:// URLs correctly."""
|
||||
agent = Agent(
|
||||
role="Test Agent",
|
||||
goal="Test goal",
|
||||
backstory="Test backstory",
|
||||
)
|
||||
|
||||
sentinel_tools = [MagicMock()]
|
||||
|
||||
with patch.object(agent, '_get_external_mcp_tools', return_value=sentinel_tools) as mock_external:
|
||||
result = agent._get_mcp_tools_from_string("https://api.example.com/mcp")
|
||||
|
||||
assert result == sentinel_tools
|
||||
mock_external.assert_called_once_with("https://api.example.com/mcp")
|
||||
|
||||
|
||||
class TestMCPServerHTTPConfig:
|
||||
"""Test MCPServerHTTP configuration with HTTP URLs."""
|
||||
|
||||
def test_mcp_server_http_accepts_http_url(self):
|
||||
"""Test that MCPServerHTTP accepts http:// URLs (prevent regression)."""
|
||||
config = MCPServerHTTP(url="http://localhost:8000/mcp")
|
||||
assert config.url == "http://localhost:8000/mcp"
|
||||
|
||||
def test_mcp_server_http_accepts_https_url(self):
|
||||
"""Test that MCPServerHTTP still accepts https:// URLs."""
|
||||
config = MCPServerHTTP(url="https://api.example.com/mcp")
|
||||
assert config.url == "https://api.example.com/mcp"
|
||||
|
||||
def test_agent_with_http_mcp_server_config(self):
|
||||
"""Test that Agent accepts MCPServerHTTP with http:// URL."""
|
||||
http_config = MCPServerHTTP(url="http://localhost:8000/mcp")
|
||||
|
||||
agent = Agent(
|
||||
role="Test Agent",
|
||||
goal="Test goal",
|
||||
backstory="Test backstory",
|
||||
mcps=[http_config],
|
||||
)
|
||||
|
||||
assert agent.mcps == [http_config]
|
||||
|
||||
|
||||
class TestHTTPMCPFragmentFiltering:
|
||||
"""Test fragment filtering for HTTP MCP URLs."""
|
||||
|
||||
def test_http_url_with_fragment_filters_correctly(self):
|
||||
"""Test that http:// URL with #tool fragment filters correctly."""
|
||||
agent = Agent(
|
||||
role="Test Agent",
|
||||
goal="Test goal",
|
||||
backstory="Test backstory",
|
||||
)
|
||||
|
||||
mock_schemas = {
|
||||
"tool1": {"description": "Tool 1"},
|
||||
"tool2": {"description": "Tool 2"},
|
||||
"specific_tool": {"description": "Specific Tool"},
|
||||
}
|
||||
|
||||
with patch.object(agent, '_get_mcp_tool_schemas', return_value=mock_schemas):
|
||||
with patch('crewai.agent.core.MCPToolWrapper') as mock_wrapper_class:
|
||||
mock_wrapper_class.return_value = MagicMock()
|
||||
|
||||
result = agent._get_external_mcp_tools("http://localhost:7365/mcp#specific_tool")
|
||||
|
||||
assert len(result) == 1
|
||||
call_args = mock_wrapper_class.call_args
|
||||
assert call_args.kwargs['tool_name'] == 'specific_tool'
|
||||
|
||||
|
||||
class TestHTTPMCPWarningLog:
|
||||
"""Test warning log for HTTP MCP URLs."""
|
||||
|
||||
def test_warning_log_emitted_for_http_url(self, caplog):
|
||||
"""Test that warning log is emitted when http:// is used."""
|
||||
agent = Agent(
|
||||
role="Test Agent",
|
||||
goal="Test goal",
|
||||
backstory="Test backstory",
|
||||
verbose=True,
|
||||
)
|
||||
|
||||
with patch.object(agent, '_get_mcp_tool_schemas', return_value={}):
|
||||
with caplog.at_level("WARNING"):
|
||||
agent._get_external_mcp_tools("http://localhost:7365/mcp")
|
||||
|
||||
assert any("http://" in record.message for record in caplog.records)
|
||||
assert any("local development" in record.message for record in caplog.records)
|
||||
assert any("https://" in record.message for record in caplog.records)
|
||||
|
||||
def test_no_warning_log_for_https_url(self, caplog):
|
||||
"""Test that no warning log is emitted for https:// URLs."""
|
||||
agent = Agent(
|
||||
role="Test Agent",
|
||||
goal="Test goal",
|
||||
backstory="Test backstory",
|
||||
verbose=True,
|
||||
)
|
||||
|
||||
with patch.object(agent, '_get_mcp_tool_schemas', return_value={}):
|
||||
with caplog.at_level("WARNING"):
|
||||
agent._get_external_mcp_tools("https://api.example.com/mcp")
|
||||
|
||||
assert not any("http://" in record.message and "local development" in record.message for record in caplog.records)
|
||||
Reference in New Issue
Block a user