fix: address flaky tests (#3363)

fix: resolve flaky tests and race conditions in test suite

- Fix telemetry/event tests by patching class methods instead of instances
- Use unique temp files/directories to prevent CI race conditions
- Reset singleton state between tests
- Mock embedchain.Client.setup() to prevent JSON corruption
- Rename test files to test_*.py convention
- Move agent tests to tests/agents directory
- Fix repeated tool usage detection
- Remove database-dependent tools causing initialization errors

tests/cli/authentication/test_utils.py

@@ -108,7 +108,9 @@ class TestValidateToken(unittest.TestCase):
 
 
 class TestTokenManager(unittest.TestCase):
-    def setUp(self):
+    @patch("crewai.cli.authentication.utils.TokenManager._get_or_create_key")
+    def setUp(self, mock_get_key):
+        mock_get_key.return_value = Fernet.generate_key()
         self.token_manager = TokenManager()
 
     @patch("crewai.cli.authentication.utils.TokenManager.read_secure_file")

tests/cli/tools/test_main.py

@@ -4,6 +4,7 @@ import unittest
 import unittest.mock
 from datetime import datetime, timedelta
 from contextlib import contextmanager
+from pathlib import Path
 from unittest import mock
 from unittest.mock import MagicMock, patch
 
@@ -27,12 +28,18 @@ def in_temp_dir():
 
 @pytest.fixture
 def tool_command():
-    TokenManager().save_tokens(
-        "test-token", (datetime.now() + timedelta(seconds=36000)).timestamp()
-    )
-    tool_command = ToolCommand()
-    with patch.object(tool_command, "login"):
-        yield tool_command
+    # Create a temporary directory for each test to avoid token storage conflicts
+    with tempfile.TemporaryDirectory() as temp_dir:
+        # Mock the secure storage path to use the temp directory
+        with patch.object(
+            TokenManager, "get_secure_storage_path", return_value=Path(temp_dir)
+        ):
+            TokenManager().save_tokens(
+                "test-token", (datetime.now() + timedelta(seconds=36000)).timestamp()
+            )
+            tool_command = ToolCommand()
+            with patch.object(tool_command, "login"):
+                yield tool_command
 
 
 @patch("crewai.cli.tools.main.subprocess.run")