From 5d18c6312d52f7a48886477dc38954daa27c7336 Mon Sep 17 00:00:00 2001
From: Rip&Tear <84775494+theCyberTech@users.noreply.github.com>
Date: Sun, 13 Oct 2024 18:09:33 +0800
Subject: [PATCH] refactered select_choice function for early return

---
 src/crewai/cli/create_crew.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/crewai/cli/create_crew.py b/src/crewai/cli/create_crew.py
index d1a362000..00fd5d5c7 100644
--- a/src/crewai/cli/create_crew.py
+++ b/src/crewai/cli/create_crew.py
@@ -69,12 +69,13 @@ def select_choice(prompt_message, choices):
     except click.exceptions.Abort:
         click.secho("Operation aborted by the user.", fg="red")
         return None
-    if 0 <= selected_index < len(choices):
-        return choices[selected_index]
-    else:
+
+    if not (0 <= selected_index < len(choices)):
         click.secho("Invalid selection.", fg="red")
         return None
 
+    return choices[selected_index]
+
 def select_provider(provider, all_providers, PROVIDERS):
     if provider and provider.lower() not in all_providers and provider.lower() != 'other':
         click.secho(f"Invalid provider: {provider}", fg="red")