From 515478473a1b709066f66bc95b2be15ca886e563 Mon Sep 17 00:00:00 2001 From: rishi154 Date: Wed, 5 Feb 2025 03:14:07 +0530 Subject: [PATCH] Fix : short_term_memory with bedrock - using user defined model(when passed as attribute) rather than default (#1959) * Update embedding_configurator.py Modified _configure_bedrock method to use user submitted model_name rather than default amazon.titan-embed-text-v1. Sending model_name in short_term_memory (embedder_config/config) was not working. # Passing model_name to use model_name provide by user than using default. Added if/else for backward compatibility * Update embedding_configurator.py Incorporated review comments --------- Co-authored-by: Brandon Hancock (bhancock_ai) <109994880+bhancockio@users.noreply.github.com> --- src/crewai/utilities/embedding_configurator.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/crewai/utilities/embedding_configurator.py b/src/crewai/utilities/embedding_configurator.py index 875dab977..ef07c8ebf 100644 --- a/src/crewai/utilities/embedding_configurator.py +++ b/src/crewai/utilities/embedding_configurator.py @@ -141,9 +141,11 @@ class EmbeddingConfigurator: AmazonBedrockEmbeddingFunction, ) - return AmazonBedrockEmbeddingFunction( - session=config.get("session"), - ) + # Allow custom model_name override with backwards compatibility + kwargs = {"session": config.get("session")} + if model_name is not None: + kwargs["model_name"] = model_name + return AmazonBedrockEmbeddingFunction(**kwargs) @staticmethod def _configure_huggingface(config, model_name):