From 4def6078ad380c4161de0fa8a1ffb592dbe6cefb Mon Sep 17 00:00:00 2001 From: lorenzejay Date: Tue, 9 Jun 2026 14:41:58 -0700 Subject: [PATCH] always defer traces for convo and so fix tests to reflect that --- lib/crewai/tests/test_flow_conversation.py | 6 ++++++ lib/crewai/tests/test_flow_definition.py | 1 + 2 files changed, 7 insertions(+) diff --git a/lib/crewai/tests/test_flow_conversation.py b/lib/crewai/tests/test_flow_conversation.py index 8d8965d7c..122ad0009 100644 --- a/lib/crewai/tests/test_flow_conversation.py +++ b/lib/crewai/tests/test_flow_conversation.py @@ -1333,6 +1333,12 @@ class TestFlowTracingWhenSuppressed: class TestDeferTraceFinalization: + def test_bare_conversational_flow_defers_by_default(self) -> None: + class BareChat(ConversationalFlow): + pass + + assert BareChat()._should_defer_trace_finalization() is True + def test_conversation_config_drives_defer_flag(self) -> None: """``ConversationConfig(defer_trace_finalization=...)`` controls whether a conversational subclass defers per-turn trace finalization.""" diff --git a/lib/crewai/tests/test_flow_definition.py b/lib/crewai/tests/test_flow_definition.py index 831a674c2..da7908798 100644 --- a/lib/crewai/tests/test_flow_definition.py +++ b/lib/crewai/tests/test_flow_definition.py @@ -221,6 +221,7 @@ def test_flow_definition_includes_conversational_builtins_when_enabled(): assert definition.conversational is not None assert definition.conversational.enabled is True + assert definition.conversational.defer_trace_finalization is True assert definition.conversational.builtin_routes == ["converse", "end"] assert "conversation_start" in methods assert "route_conversation" in methods