andre/crewAI
1
0
Fork 0
mirror of https://github.com/crewAIInc/crewAI.git synced 2026-01-11 09:08:31 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Apply automatic linting fixes to tests directory

Browse Source 
Co-Authored-By: Joe Moura <joao@crewai.com>
This commit is contained in:
Devin AI
2025-05-12 13:31:07 +00:00
parent ad1ea46bbb
commit 46621113af
62 changed files with 1738 additions and 1821 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
tests/memory/external_memory_test.py
View File

@@ -13,8 +13,7 @@ from crewai.task import Task
@pytest.fixture
def mock_mem0_memory():
mock_memory = MagicMock(spec=Memory)
return mock_memory
return MagicMock(spec=Memory)
@pytest.fixture
@@ -29,8 +28,7 @@ def patch_configure_mem0(mock_mem0_memory):
@pytest.fixture
def external_memory_with_mocked_config(patch_configure_mem0):
embedder_config = {"provider": "mem0"}
external_memory = ExternalMemory(embedder_config=embedder_config)
return external_memory
return ExternalMemory(embedder_config=embedder_config)
@pytest.fixture
@@ -49,7 +47,7 @@ def crew_with_external_memory(external_memory_with_mocked_config, patch_configur
agent=agent,
)
crew = Crew(
return Crew(
agents=[agent],
tasks=[task],
verbose=True,
@@ -58,12 +56,11 @@ def crew_with_external_memory(external_memory_with_mocked_config, patch_configur
external_memory=external_memory_with_mocked_config,
)
return crew
@pytest.fixture
def crew_with_external_memory_without_memory_flag(
external_memory_with_mocked_config, patch_configure_mem0
external_memory_with_mocked_config, patch_configure_mem0,
):
agent = Agent(
role="Researcher",
@@ -79,7 +76,7 @@ def crew_with_external_memory_without_memory_flag(
agent=agent,
)
crew = Crew(
return Crew(
agents=[agent],
tasks=[task],
verbose=True,
@@ -87,17 +84,16 @@ def crew_with_external_memory_without_memory_flag(
external_memory=external_memory_with_mocked_config,
)
return crew
def test_external_memory_initialization(external_memory_with_mocked_config):
def test_external_memory_initialization(external_memory_with_mocked_config) -> None:
assert external_memory_with_mocked_config is not None
assert isinstance(external_memory_with_mocked_config, ExternalMemory)
def test_external_memory_save(external_memory_with_mocked_config):
def test_external_memory_save(external_memory_with_mocked_config) -> None:
memory_item = ExternalMemoryItem(
value="test value", metadata={"task": "test_task"}, agent="test_agent"
value="test value", metadata={"task": "test_task"}, agent="test_agent",
)
with patch.object(ExternalMemory, "save") as mock_save:
@@ -114,51 +110,51 @@ def test_external_memory_save(external_memory_with_mocked_config):
)
def test_external_memory_reset(external_memory_with_mocked_config):
def test_external_memory_reset(external_memory_with_mocked_config) -> None:
with patch(
"crewai.memory.external.external_memory.ExternalMemory.reset"
"crewai.memory.external.external_memory.ExternalMemory.reset",
) as mock_reset:
external_memory_with_mocked_config.reset()
mock_reset.assert_called_once()
def test_external_memory_supported_storages():
def test_external_memory_supported_storages() -> None:
supported_storages = ExternalMemory.external_supported_storages()
assert "mem0" in supported_storages
assert callable(supported_storages["mem0"])
def test_external_memory_create_storage_invalid_provider():
def test_external_memory_create_storage_invalid_provider() -> None:
embedder_config = {"provider": "invalid_provider", "config": {}}
with pytest.raises(ValueError, match="Provider invalid_provider not supported"):
ExternalMemory.create_storage(None, embedder_config)
def test_external_memory_create_storage_missing_provider():
def test_external_memory_create_storage_missing_provider() -> None:
embedder_config = {"config": {}}
with pytest.raises(
ValueError, match="embedder_config must include a 'provider' key"
ValueError, match="embedder_config must include a 'provider' key",
):
ExternalMemory.create_storage(None, embedder_config)
def test_external_memory_create_storage_missing_config():
def test_external_memory_create_storage_missing_config() -> None:
with pytest.raises(ValueError, match="embedder_config is required"):
ExternalMemory.create_storage(None, None)
def test_crew_with_external_memory_initialization(crew_with_external_memory):
def test_crew_with_external_memory_initialization(crew_with_external_memory) -> None:
assert crew_with_external_memory._external_memory is not None
assert isinstance(crew_with_external_memory._external_memory, ExternalMemory)
assert crew_with_external_memory._external_memory.crew == crew_with_external_memory
@pytest.mark.parametrize("mem_type", ["external", "all"])
def test_crew_external_memory_reset(mem_type, crew_with_external_memory):
def test_crew_external_memory_reset(mem_type, crew_with_external_memory) -> None:
with patch(
"crewai.memory.external.external_memory.ExternalMemory.reset"
"crewai.memory.external.external_memory.ExternalMemory.reset",
) as mock_reset:
crew_with_external_memory.reset_memories(mem_type)
mock_reset.assert_called_once()
@@ -167,10 +163,10 @@ def test_crew_external_memory_reset(mem_type, crew_with_external_memory):
@pytest.mark.parametrize("mem_method", ["search", "save"])
@pytest.mark.vcr(filter_headers=["authorization"])
def test_crew_external_memory_save_with_memory_flag(
mem_method, crew_with_external_memory
):
mem_method, crew_with_external_memory,
) -> None:
with patch(
f"crewai.memory.external.external_memory.ExternalMemory.{mem_method}"
f"crewai.memory.external.external_memory.ExternalMemory.{mem_method}",
) as mock_method:
crew_with_external_memory.kickoff()
assert mock_method.call_count > 0
@@ -179,27 +175,27 @@ def test_crew_external_memory_save_with_memory_flag(
@pytest.mark.parametrize("mem_method", ["search", "save"])
@pytest.mark.vcr(filter_headers=["authorization"])
def test_crew_external_memory_save_using_crew_without_memory_flag(
mem_method, crew_with_external_memory_without_memory_flag
):
mem_method, crew_with_external_memory_without_memory_flag,
) -> None:
with patch(
f"crewai.memory.external.external_memory.ExternalMemory.{mem_method}"
f"crewai.memory.external.external_memory.ExternalMemory.{mem_method}",
) as mock_method:
crew_with_external_memory_without_memory_flag.kickoff()
assert mock_method.call_count > 0
def test_external_memory_custom_storage(crew_with_external_memory):
def test_external_memory_custom_storage(crew_with_external_memory) -> None:
class CustomStorage(Storage):
def __init__(self):
def __init__(self) -> None:
self.memories = []
def save(self, value, metadata=None, agent=None):
def save(self, value, metadata=None, agent=None) -> None:
self.memories.append({"value": value, "metadata": metadata, "agent": agent})
def search(self, query, limit=10, score_threshold=0.5):
return self.memories
def reset(self):
def reset(self) -> None:
self.memories = []
custom_storage = CustomStorage()

4
tests/memory/long_term_memory_test.py
View File

@@ -6,11 +6,11 @@ from crewai.memory.long_term.long_term_memory_item import LongTermMemoryItem
@pytest.fixture
def long_term_memory():
"""Fixture to create a LongTermMemory instance"""
"""Fixture to create a LongTermMemory instance."""
return LongTermMemory()
def test_save_and_search(long_term_memory):
def test_save_and_search(long_term_memory) -> None:
memory = LongTermMemoryItem(
agent="test_agent",
task="test_task",

6
tests/memory/short_term_memory_test.py
View File

@@ -11,7 +11,7 @@ from crewai.task import Task
@pytest.fixture
def short_term_memory():
"""Fixture to create a ShortTermMemory instance"""
"""Fixture to create a ShortTermMemory instance."""
agent = Agent(
role="Researcher",
goal="Search relevant data and provide results",
@@ -28,7 +28,7 @@ def short_term_memory():
return ShortTermMemory(crew=Crew(agents=[agent], tasks=[task]))
def test_save_and_search(short_term_memory):
def test_save_and_search(short_term_memory) -> None:
memory = ShortTermMemoryItem(
data="""test value test value test value test value test value test value
test value test value test value test value test value test value
@@ -55,7 +55,7 @@ def test_save_and_search(short_term_memory):
"context": memory.data,
"metadata": {"agent": "test_agent"},
"score": 0.95,
}
},
]
with patch.object(ShortTermMemory, "search", return_value=expected_result):
find = short_term_memory.search("test value", score_threshold=0.01)[0]

25
tests/memory/user_memory_test.py
View File

@@ -8,28 +8,27 @@ from crewai.memory.user.user_memory_item import UserMemoryItem
class MockCrew:
def __init__(self, memory_config):
def __init__(self, memory_config) -> None:
self.memory_config = memory_config
@pytest.fixture
def user_memory():
"""Fixture to create a UserMemory instance"""
"""Fixture to create a UserMemory instance."""
crew = MockCrew(
memory_config={
"provider": "mem0",
"config": {"user_id": "john"},
"user_memory" : {}
}
"user_memory" : {},
},
)
user_memory = MagicMock(spec=UserMemory)
with patch.object(Memory,'__new__',return_value=user_memory):
user_memory_instance = UserMemory(crew=crew)
return user_memory_instance
with patch.object(Memory,"__new__",return_value=user_memory):
return UserMemory(crew=crew)
def test_save_and_search(user_memory):
def test_save_and_search(user_memory) -> None:
memory = UserMemoryItem(
data="""test value test value test value test value test value test value
test value test value test value test value test value test value
@@ -42,13 +41,13 @@ def test_save_and_search(user_memory):
user_memory.save(
value=memory.data,
metadata=memory.metadata,
user=memory.user
user=memory.user,
)
mock_save.assert_called_once_with(
value=memory.data,
metadata=memory.metadata,
user=memory.user
user=memory.user,
)
expected_result = [
@@ -56,12 +55,12 @@ def test_save_and_search(user_memory):
"context": memory.data,
"metadata": {"agent": "test_agent"},
"score": 0.95,
}
},
]
expected_result = ["mocked_result"]
# Use patch.object to mock UserMemory's search method
with patch.object(UserMemory, 'search', return_value=expected_result) as mock_search:
with patch.object(UserMemory, "search", return_value=expected_result) as mock_search:
find = UserMemory.search("test value", score_threshold=0.01)[0]
mock_search.assert_called_once_with("test value", score_threshold=0.01)
assert find == expected_result[0]