andre/crewAI
1
0
Fork 0
mirror of https://github.com/crewAIInc/crewAI.git synced 2026-01-10 08:38:30 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Address PR feedback: Add validation, refactor code duplication, enhance tests

Browse Source 
- Add regex pattern validation for execution_image parameter
- Refactor get_code_execution_tools() to eliminate code duplication using tool_kwargs
- Add comprehensive tests for invalid Docker image format validation
- Add tests for various valid Docker image formats
- Update documentation with best practices section for custom Docker images
- Fix lint issues: remove unused imports and variables

Addresses feedback from joaomdmoura in PR #2934

Co-Authored-By: João <joao@crewai.com>
This commit is contained in:
Devin AI
2025-06-02 18:23:11 +00:00
parent 229bbd9bbe
commit 45404537fd
4 changed files with 69 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/test_custom_execution_image_integration.py
View File

@@ -1,4 +1,3 @@
import pytest
from unittest.mock import patch, MagicMock
from crewai import Agent, Task, Crew
@@ -28,7 +27,7 @@ def test_crew_with_custom_execution_image_integration(mock_code_interpreter_clas
tasks=[task]
)
tools = crew._prepare_tools(task, agent)
crew._prepare_tools(task, agent)
mock_code_interpreter_class.assert_called_with(
unsafe_mode=False,