From 3f20ef101c29a0323eb5c34d2a9fb3ceb3008ede Mon Sep 17 00:00:00 2001
From: Brandon Hancock <brandon@brandonhancock.io>
Date: Thu, 9 Jan 2025 15:11:39 -0500
Subject: [PATCH] Trying to fix tests

---
 tests/test_manager_llm_delegation.py | 58 +++++++++++++---------------
 1 file changed, 27 insertions(+), 31 deletions(-)

diff --git a/tests/test_manager_llm_delegation.py b/tests/test_manager_llm_delegation.py
index 6b1b97b9a..ce02fa120 100644
--- a/tests/test_manager_llm_delegation.py
+++ b/tests/test_manager_llm_delegation.py
@@ -1,8 +1,6 @@
-from unittest.mock import MagicMock
-
 import pytest
 
-from crewai import Agent, Task
+from crewai import Agent
 from crewai.tools.agent_tools.base_agent_tools import BaseAgentTool
 
 
@@ -14,9 +12,8 @@ class InternalAgentTool(BaseAgentTool):
         return "Test response"
 
 
-@pytest.mark.parametrize(
-    "role_name,should_match",
-    [
+def test_agent_tool_role_matching():
+    test_cases = [
         ("Futel Official Infopoint", True),  # exact match
         ('  "Futel Official Infopoint"  ', True),  # extra quotes and spaces
         ("Futel Official Infopoint\n", True),  # trailing newline
@@ -26,31 +23,30 @@ class InternalAgentTool(BaseAgentTool):
         ("FUTEL OFFICIAL INFOPOINT", True),  # uppercase
         ("Non Existent Agent", False),  # non-existent agent
         (None, False),  # None agent name
-    ],
-)
-def test_agent_tool_role_matching(role_name, should_match):
-    """Test that agent tools can match roles regardless of case, whitespace, and special characters."""
-    # Create test agent
-    test_agent = Agent(
-        role="Futel Official Infopoint",
-        goal="Answer questions about Futel",
-        backstory="Futel Football Club info",
-        allow_delegation=False,
-    )
+    ]
 
-    # Create test agent tool
-    agent_tool = InternalAgentTool(
-        name="test_tool", description="Test tool", agents=[test_agent]
-    )
+    for role_name, should_match in test_cases:
+        # Setup your test agent and agent tool
+        test_agent = Agent(
+            role="Futel Official Infopoint",
+            goal="Answer questions about Futel",
+            backstory="Futel Football Club info",
+            allow_delegation=False,
+        )
+        agent_tool = InternalAgentTool(
+            name="test_tool", description="Test tool", agents=[test_agent]
+        )
 
-    # Test role matching
-    result = agent_tool._execute(agent_name=role_name, task="Test task", context=None)
+        # Execute the test using _execute
+        result = agent_tool._execute(
+            agent_name=role_name, task="Test task", context=None
+        )
 
-    if should_match:
-        assert (
-            "coworker mentioned not found" not in result.lower()
-        ), f"Should find agent with role name: {role_name}"
-    else:
-        assert (
-            "coworker mentioned not found" in result.lower()
-        ), f"Should not find agent with role name: {role_name}"
+        if should_match:
+            assert (
+                "coworker mentioned not found" not in result.lower()
+            ), f"Should find agent with role name: {role_name}"
+        else:
+            assert (
+                "coworker mentioned not found" in result.lower()
+            ), f"Should not find agent with role name: {role_name}"