From 38c0d61b1132dd32d6221559efecae9667f4bc50 Mon Sep 17 00:00:00 2001 From: Lorenze Jay Date: Wed, 20 Nov 2024 14:02:12 -0800 Subject: [PATCH] more fixes --- src/crewai/knowledge/knowledge.py | 4 ++-- src/crewai/knowledge/source/base_knowledge_source.py | 2 +- src/crewai/utilities/constants.py | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/crewai/knowledge/knowledge.py b/src/crewai/knowledge/knowledge.py index 6c0b819cc..a77c4116f 100644 --- a/src/crewai/knowledge/knowledge.py +++ b/src/crewai/knowledge/knowledge.py @@ -6,7 +6,7 @@ from pydantic import BaseModel, ConfigDict, Field from crewai.knowledge.source.base_knowledge_source import BaseKnowledgeSource from crewai.knowledge.storage.knowledge_storage import KnowledgeStorage from crewai.utilities.logger import Logger - +from crewai.utilities.constants import DEFAULT_SCORE_THRESHOLD os.environ["TOKENIZERS_PARALLELISM"] = "false" # removes logging from fastembed @@ -42,6 +42,6 @@ class Knowledge(BaseModel): query, limit, filter={"preference": preference} if preference else None, - score_threshold=0.35, + score_threshold=DEFAULT_SCORE_THRESHOLD, ) return results diff --git a/src/crewai/knowledge/source/base_knowledge_source.py b/src/crewai/knowledge/source/base_knowledge_source.py index a2a79cf79..bb4c69cf3 100644 --- a/src/crewai/knowledge/source/base_knowledge_source.py +++ b/src/crewai/knowledge/source/base_knowledge_source.py @@ -20,7 +20,7 @@ class BaseKnowledgeSource(BaseModel, ABC): metadata: Dict[str, Any] = Field(default_factory=dict) @abstractmethod - def load_content(self): + def load_content(self) -> Dict[Any, str]: """Load and preprocess content from the source.""" pass diff --git a/src/crewai/utilities/constants.py b/src/crewai/utilities/constants.py index 22cc2ffbe..59f789913 100644 --- a/src/crewai/utilities/constants.py +++ b/src/crewai/utilities/constants.py @@ -1,2 +1,3 @@ TRAINING_DATA_FILE = "training_data.pkl" TRAINED_AGENTS_DATA_FILE = "trained_agents_data.pkl" +DEFAULT_SCORE_THRESHOLD = 0.35