From 35f6156ed43ebd04be2686827055b4d96ef46e82 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Moura?= Date: Wed, 3 Apr 2024 05:03:43 -0300 Subject: [PATCH] checking crew before using memory --- src/crewai/agents/executor.py | 5 +++-- src/crewai/crew.py | 7 ------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/crewai/agents/executor.py b/src/crewai/agents/executor.py index bbf5d789c..f2c4c02a1 100644 --- a/src/crewai/agents/executor.py +++ b/src/crewai/agents/executor.py @@ -53,7 +53,8 @@ class CrewAgentExecutor(AgentExecutor): def _create_short_term_memory(self, output) -> None: if ( - self.crew_agent.memory + self.crew + and self.crew_agent.memory and "Action: Delegate work to co-worker" not in output.log ): memory = ShortTermMemoryItem( @@ -66,7 +67,7 @@ class CrewAgentExecutor(AgentExecutor): self.crew._short_term_memory.save(memory) def _create_long_term_memory(self, output) -> None: - if self.crew_agent.memory: + if self.crew and self.crew_agent.memory: ltm_agent = TaskEvaluator(self.crew_agent) evaluation = ltm_agent.evaluate(self.task, output.log) diff --git a/src/crewai/crew.py b/src/crewai/crew.py index 6492a2204..75ff1d608 100644 --- a/src/crewai/crew.py +++ b/src/crewai/crew.py @@ -1,8 +1,5 @@ import json -import subprocess -import sys import uuid -from pathlib import Path from typing import Any, Dict, List, Optional, Union from langchain_core.callbacks import BaseCallbackHandler @@ -158,10 +155,6 @@ class Crew(BaseModel): def create_crew_memory(self) -> "Crew": """Set private attributes.""" if self.memory: - storage_dir = Path(".db") - storage_dir.mkdir(exist_ok=True) - if sys.platform.startswith("win"): - subprocess.call(["attrib", "+H", str(storage_dir)]) self._long_term_memory = LongTermMemory() self._short_term_memory = ShortTermMemory(embedder_config=self.embedder) self._entity_memory = EntityMemory(embedder_config=self.embedder)