Address PR review feedback: Move model list to class constant, optimize methods, add docstrings, enhance tests

Co-Authored-By: Joe Moura <joao@crewai.com>

tests/llm_test.py

@@ -30,31 +30,39 @@ def test_llm_callback_replacement():
     assert usage_metrics_1 == calc_handler_1.token_cost_process.get_summary()
 
 
-def test_supports_stop_words_for_o3_model():
-    """Test that supports_stop_words returns False for o3 model."""
-    llm = LLM(model="o3")
-    assert not llm.supports_stop_words()
-
-
-def test_supports_stop_words_for_o4_mini_model():
-    """Test that supports_stop_words returns False for o4-mini model."""
-    llm = LLM(model="o4-mini")
-    assert not llm.supports_stop_words()
-
-
-@pytest.mark.vcr(filter_headers=["authorization"])
-def test_llm_call_excludes_stop_parameter_for_unsupported_models(monkeypatch):
-    """Test that the LLM.call method excludes the stop parameter for models that don't support it."""
-    def mock_completion(**kwargs):
-        assert 'stop' not in kwargs, "Stop parameter should be excluded for o3 model"
-        return {"choices": [{"message": {"content": "Hello, World!"}}]}
+class TestLLMStopWords:
+    """Tests for LLM stop words functionality."""
     
-    monkeypatch.setattr("litellm.completion", mock_completion)
+    def test_supports_stop_words_for_o3_model(self):
+        """Test that supports_stop_words returns False for o3 model."""
+        llm = LLM(model="o3")
+        assert not llm.supports_stop_words()
     
-    llm = LLM(model="o3")
-    llm.stop = ["STOP"]
+    def test_supports_stop_words_for_o4_mini_model(self):
+        """Test that supports_stop_words returns False for o4-mini model."""
+        llm = LLM(model="o4-mini")
+        assert not llm.supports_stop_words()
     
-    messages = [{"role": "user", "content": "Say 'Hello, World!'"}]
-    response = llm.call(messages)
+    def test_supports_stop_words_for_supported_model(self):
+        """Test that supports_stop_words returns True for models that support stop words."""
+        llm = LLM(model="gpt-4")
+        assert llm.supports_stop_words()
     
-    assert response == "Hello, World!"
+    @pytest.mark.vcr(filter_headers=["authorization"])
+    def test_llm_call_excludes_stop_parameter_for_unsupported_models(self, monkeypatch):
+        """Test that the LLM.call method excludes the stop parameter for models that don't support it."""
+        def mock_completion(**kwargs):
+            assert 'stop' not in kwargs, "Stop parameter should be excluded for o3 model"
+            assert 'model' in kwargs, "Model parameter should be included"
+            assert 'messages' in kwargs, "Messages parameter should be included"
+            return {"choices": [{"message": {"content": "Hello, World!"}}]}
+        
+        monkeypatch.setattr("litellm.completion", mock_completion)
+        
+        llm = LLM(model="o3")
+        llm.stop = ["STOP"]
+        
+        messages = [{"role": "user", "content": "Say 'Hello, World!'"}]
+        response = llm.call(messages)
+        
+        assert response == "Hello, World!"