From 2e5bb3f856b1e9c751533e21401ac0c9ca935901 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Moura?= Date: Fri, 27 Dec 2024 16:16:39 -0300 Subject: [PATCH] fix linter and types --- src/crewai/tools/agent_tools/add_image_tool.py | 11 ++++++----- tests/knowledge/knowledge_test.py | 1 - tests/test_task_guardrails.py | 1 - 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/crewai/tools/agent_tools/add_image_tool.py b/src/crewai/tools/agent_tools/add_image_tool.py index 1650ceafe..6b081ba2e 100644 --- a/src/crewai/tools/agent_tools/add_image_tool.py +++ b/src/crewai/tools/agent_tools/add_image_tool.py @@ -1,12 +1,13 @@ from crewai.tools.base_tool import BaseTool from crewai.utilities import I18N from pydantic import BaseModel, Field +from typing import Optional i18n = I18N() class AddImageToolSchema(BaseModel): image_url: str = Field(..., description="The URL or path of the image to add") - action: str = Field( + action: Optional[str] = Field( default=None, description="Optional context or question about the image" ) @@ -15,17 +16,17 @@ class AddImageToolSchema(BaseModel): class AddImageTool(BaseTool): """Tool for adding images to the content""" - name: str = Field(default_factory=lambda: i18n.tools("add_image")["name"]) - description: str = Field(default_factory=lambda: i18n.tools("add_image")["description"]) + name: str = Field(default_factory=lambda: i18n.tools("add_image").get("name")) + description: str = Field(default_factory=lambda: i18n.tools("add_image").get("description")) args_schema: type[BaseModel] = AddImageToolSchema def _run( self, image_url: str, - action: str = None, + action: Optional[str] = None, **kwargs, ) -> dict: - action = action or i18n.tools("add_image")["default_action"] + action = action or i18n.tools("add_image").get("default_action") content = [ {"type": "text", "text": action}, { diff --git a/tests/knowledge/knowledge_test.py b/tests/knowledge/knowledge_test.py index 366067587..ed3519c35 100644 --- a/tests/knowledge/knowledge_test.py +++ b/tests/knowledge/knowledge_test.py @@ -5,7 +5,6 @@ from typing import List, Union from unittest.mock import patch import pytest - from crewai.knowledge.source.crew_docling_source import CrewDoclingSource from crewai.knowledge.source.csv_knowledge_source import CSVKnowledgeSource from crewai.knowledge.source.excel_knowledge_source import ExcelKnowledgeSource diff --git a/tests/test_task_guardrails.py b/tests/test_task_guardrails.py index dc96cb878..c788fd9dc 100644 --- a/tests/test_task_guardrails.py +++ b/tests/test_task_guardrails.py @@ -3,7 +3,6 @@ from unittest.mock import Mock import pytest - from crewai.task import Task from crewai.tasks.task_output import TaskOutput