From 2d23ef7e12295fe6172c3fd8ed5a50d05ddecfbd Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Fri, 27 Dec 2024 20:54:14 +0000 Subject: [PATCH] fix: improve type narrowing in Knowledge.query with local variable Co-Authored-By: Joe Moura --- src/crewai/knowledge/knowledge.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/crewai/knowledge/knowledge.py b/src/crewai/knowledge/knowledge.py index f377a49ea..b6f753b39 100644 --- a/src/crewai/knowledge/knowledge.py +++ b/src/crewai/knowledge/knowledge.py @@ -53,10 +53,11 @@ class Knowledge(BaseModel): Raises: ValueError: If no storage is configured for querying. """ - if self.storage is None: + storage = self.storage + if storage is None: raise ValueError("No storage found to perform query.") - - results = self.storage.search( + # Assign to local variable to help mypy with type narrowing + results = storage.search( query, limit, )