From 2c12b91083aa6f4416b0cbc62ce615e3e5d9f161 Mon Sep 17 00:00:00 2001
From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Date: Fri, 27 Dec 2024 20:55:45 +0000
Subject: [PATCH] fix: use isinstance for proper type narrowing in
 Knowledge.query

Co-Authored-By: Joe Moura <joao@crewai.com>
---
 src/crewai/knowledge/knowledge.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/crewai/knowledge/knowledge.py b/src/crewai/knowledge/knowledge.py
index b6f753b39..3696a1b1f 100644
--- a/src/crewai/knowledge/knowledge.py
+++ b/src/crewai/knowledge/knowledge.py
@@ -54,9 +54,9 @@ class Knowledge(BaseModel):
             ValueError: If no storage is configured for querying.
         """
         storage = self.storage
-        if storage is None:
+        if not isinstance(storage, KnowledgeStorage):
             raise ValueError("No storage found to perform query.")
-        # Assign to local variable to help mypy with type narrowing
+        # Using isinstance check for proper type narrowing
         results = storage.search(
             query,
             limit,