mirror of
https://github.com/crewAIInc/crewAI.git
synced 2026-01-14 02:28:30 +00:00
Address security concerns and add more tests for SSL verification fallback
Co-Authored-By: Joe Moura <joao@crewai.com>
This commit is contained in:
@@ -45,7 +45,6 @@ class TestProviderFunctions:
|
||||
assert result == {"test": "data"}
|
||||
assert mock_get.call_count == 2
|
||||
|
||||
|
||||
assert mock_get.call_args_list[1][1]["verify"] is False
|
||||
|
||||
mock_secho.assert_any_call(
|
||||
@@ -53,3 +52,58 @@ class TestProviderFunctions:
|
||||
"This is less secure but may be necessary on some systems.",
|
||||
fg="yellow"
|
||||
)
|
||||
|
||||
@mock.patch("crewai.cli.provider.requests.get")
|
||||
@mock.patch("crewai.cli.provider.click.secho")
|
||||
@mock.patch.dict(os.environ, {"CREW_ALLOW_INSECURE_SSL": "true"})
|
||||
def test_fetch_provider_data_with_insecure_env_var(self, mock_secho, mock_get):
|
||||
mock_response = mock.MagicMock()
|
||||
mock_response.headers.get.return_value = "100"
|
||||
mock_response.iter_content.return_value = [b'{"test": "data"}']
|
||||
mock_get.return_value = mock_response
|
||||
|
||||
with tempfile.NamedTemporaryFile() as temp_file:
|
||||
cache_file = Path(temp_file.name)
|
||||
result = fetch_provider_data(cache_file)
|
||||
|
||||
assert result == {"test": "data"}
|
||||
mock_get.assert_called_once()
|
||||
|
||||
assert mock_get.call_args[1]["verify"] is False
|
||||
|
||||
mock_secho.assert_any_call(
|
||||
"SSL verification disabled via environment variable. "
|
||||
"This is less secure and should only be used in development environments.",
|
||||
fg="yellow"
|
||||
)
|
||||
|
||||
@mock.patch("crewai.cli.provider.requests.get")
|
||||
def test_fetch_provider_data_with_empty_response(self, mock_get):
|
||||
mock_response = mock.MagicMock()
|
||||
mock_response.headers.get.return_value = "0"
|
||||
mock_response.iter_content.return_value = [b'{}']
|
||||
mock_get.return_value = mock_response
|
||||
|
||||
with tempfile.NamedTemporaryFile() as temp_file:
|
||||
cache_file = Path(temp_file.name)
|
||||
result = fetch_provider_data(cache_file)
|
||||
|
||||
assert result == {}
|
||||
mock_get.assert_called_once()
|
||||
|
||||
@mock.patch("crewai.cli.provider.requests.get")
|
||||
@mock.patch("crewai.cli.provider.click.secho")
|
||||
def test_fetch_provider_data_request_exception(self, mock_secho, mock_get):
|
||||
mock_get.side_effect = requests.RequestException("Connection error")
|
||||
|
||||
with tempfile.NamedTemporaryFile() as temp_file:
|
||||
cache_file = Path(temp_file.name)
|
||||
result = fetch_provider_data(cache_file)
|
||||
|
||||
assert result is None
|
||||
mock_get.assert_called_once()
|
||||
|
||||
mock_secho.assert_any_call(
|
||||
"Error fetching provider data: Connection error",
|
||||
fg="red"
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user