mirror of
https://github.com/crewAIInc/crewAI.git
synced 2026-01-11 09:08:31 +00:00
Address CI failures and code review feedback
- Remove unused pytest imports from test files (fixes lint errors) - Fix CodeQL security alert by using exact URL validation instead of substring check - Enhance SSL function documentation with detailed environment variable precedence - Improve error handling in fetch_provider_data with current CA bundle path display - Add more helpful guidance for SSL certificate configuration issues Addresses feedback from AI code review and resolves CI lint/security failures. Co-Authored-By: João <joao@crewai.com>
This commit is contained in:
@@ -1,5 +1,3 @@
|
||||
import pytest
|
||||
|
||||
from crewai.cli.constants import ENV_VARS, JSON_URL, MODELS, PROVIDERS
|
||||
|
||||
|
||||
@@ -26,4 +24,4 @@ def test_huggingface_models():
|
||||
def test_json_url_is_https():
|
||||
"""Test that JSON_URL uses HTTPS for secure connection."""
|
||||
assert JSON_URL.startswith("https://")
|
||||
assert "raw.githubusercontent.com" in JSON_URL
|
||||
assert JSON_URL == "https://raw.githubusercontent.com/BerriAI/litellm/main/model_prices_and_context_window.json"
|
||||
|
||||
@@ -3,7 +3,6 @@ import tempfile
|
||||
from pathlib import Path
|
||||
from unittest.mock import Mock, patch
|
||||
|
||||
import pytest
|
||||
import requests
|
||||
|
||||
from crewai.cli.provider import fetch_provider_data, get_ssl_verify_config
|
||||
|
||||
Reference in New Issue
Block a user