From 1890e6e111173ea8ee8bb6e9299d125c8a7f6107 Mon Sep 17 00:00:00 2001
From: rishi154 <rishi154@gmail.com>
Date: Thu, 23 Jan 2025 21:43:56 +0530
Subject: [PATCH] Update embedding_configurator.py

Incorporated review comments
---
 src/crewai/utilities/embedding_configurator.py | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/src/crewai/utilities/embedding_configurator.py b/src/crewai/utilities/embedding_configurator.py
index df9eda399..44a54a85b 100644
--- a/src/crewai/utilities/embedding_configurator.py
+++ b/src/crewai/utilities/embedding_configurator.py
@@ -142,16 +142,11 @@ class EmbeddingConfigurator:
             AmazonBedrockEmbeddingFunction,
         )
 
-        # Passing model_name to use model_name provide by user than using default. Added if/else for backward compatibility
-        if model_name==None:
-            return AmazonBedrockEmbeddingFunction(
-                session=config.get("session"),
-            )
-        else:
-            return AmazonBedrockEmbeddingFunction(
-                session=config.get("session"),
-                model_name=model_name
-            )
+        # Allow custom model_name override with backwards compatibility
+        kwargs = {"session": config.get("session")}
+        if model_name is not None:
+            kwargs["model_name"] = model_name
+        return AmazonBedrockEmbeddingFunction(**kwargs)
 
     @staticmethod
     def _configure_huggingface(config, model_name):