From 17efd214fbe96bd46aba8c9c3c6fdfd0b497587c Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Tue, 6 May 2025 22:51:29 +0000 Subject: [PATCH] docs: improve documentation and test assertions as per PR review Co-Authored-By: Joe Moura --- src/crewai/tools/agent_tools/delegate_work_tool.py | 7 ++++++- tests/test_hierarchical_issue_fix.py | 11 ++++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/src/crewai/tools/agent_tools/delegate_work_tool.py b/src/crewai/tools/agent_tools/delegate_work_tool.py index 1430798bd..26076bb7b 100644 --- a/src/crewai/tools/agent_tools/delegate_work_tool.py +++ b/src/crewai/tools/agent_tools/delegate_work_tool.py @@ -14,7 +14,12 @@ class DelegateWorkToolSchema(BaseModel): class DelegateWorkTool(BaseAgentTool): - """Tool for delegating work to coworkers""" + """Tool for delegating work to other agents in the crew. + + Attributes: + result_as_answer (bool): When True, returns the delegated agent's result + as the final answer instead of metadata about delegation. + """ name: str = "Delegate work to coworker" args_schema: type[BaseModel] = DelegateWorkToolSchema diff --git a/tests/test_hierarchical_issue_fix.py b/tests/test_hierarchical_issue_fix.py index b668097e7..a792a7ded 100644 --- a/tests/test_hierarchical_issue_fix.py +++ b/tests/test_hierarchical_issue_fix.py @@ -1,6 +1,7 @@ """Test to ensure hierarchical process mode returns complete final answers.""" import pytest + from crewai.agent import Agent from crewai.crew import Crew from crewai.process import Process @@ -9,7 +10,14 @@ from crewai.task import Task @pytest.mark.vcr(filter_headers=["authorization"]) def test_hierarchical_process_delegation_result(): - """Test that the hierarchical process returns the delegated agent's result, not just the manager's delegation thought.""" + """Tests hierarchical process delegation result handling. + + Ensures that: + 1. The output is derived from the delegated agent's actual work. + 2. The response does not contain delegation-related metadata. + 3. The content meets minimum length requirements. + 4. Expected topic-related keywords are present in the output. + """ researcher = Agent( role="Researcher", goal="Make the best research and analysis on content about AI and AI agents", @@ -40,6 +48,7 @@ def test_hierarchical_process_delegation_result(): assert "idea" in result.raw.lower() or "article" in result.raw.lower() assert len(result.raw) > 100 # Ensure we have substantial content + assert result.raw.count('\n') >= 6 # At least 3 ideas with paragraphs assert "delegate" not in result.raw.lower() assert "delegating" not in result.raw.lower()