test: use scoped_handlers while listener Memory events

This commit is contained in:
Lucas Gomide
2025-07-01 23:07:56 -03:00
parent 15c5654a70
commit 174215980b
4 changed files with 119 additions and 124 deletions

View File

@@ -2499,6 +2499,7 @@ def test_using_contextual_memory():
def test_memory_events_are_emitted(): def test_memory_events_are_emitted():
events = defaultdict(list) events = defaultdict(list)
with crewai_event_bus.scoped_handlers():
@crewai_event_bus.on(MemorySaveStartedEvent) @crewai_event_bus.on(MemorySaveStartedEvent)
def handle_memory_save_started(source, event): def handle_memory_save_started(source, event):
events["MemorySaveStartedEvent"].append(event) events["MemorySaveStartedEvent"].append(event)

View File

@@ -238,7 +238,7 @@ def test_external_memory_search_events(custom_storage, external_memory_with_mock
events = defaultdict(list) events = defaultdict(list)
external_memory_with_mocked_config.storage = custom_storage external_memory_with_mocked_config.storage = custom_storage
with crewai_event_bus.scoped_handlers():
@crewai_event_bus.on(MemoryQueryStartedEvent) @crewai_event_bus.on(MemoryQueryStartedEvent)
def on_search_started(source, event): def on_search_started(source, event):
events["MemoryQueryStartedEvent"].append(event) events["MemoryQueryStartedEvent"].append(event)
@@ -281,7 +281,6 @@ def test_external_memory_search_events(custom_storage, external_memory_with_mock
'query_time_ms': ANY 'query_time_ms': ANY
} }
crewai_event_bus._handlers.clear()
def test_external_memory_save_events(custom_storage, external_memory_with_mocked_config): def test_external_memory_save_events(custom_storage, external_memory_with_mocked_config):
@@ -289,6 +288,7 @@ def test_external_memory_save_events(custom_storage, external_memory_with_mocked
external_memory_with_mocked_config.storage = custom_storage external_memory_with_mocked_config.storage = custom_storage
with crewai_event_bus.scoped_handlers():
@crewai_event_bus.on(MemorySaveStartedEvent) @crewai_event_bus.on(MemorySaveStartedEvent)
def on_save_started(source, event): def on_save_started(source, event):
events["MemorySaveStartedEvent"].append(event) events["MemorySaveStartedEvent"].append(event)
@@ -329,5 +329,3 @@ def test_external_memory_save_events(custom_storage, external_memory_with_mocked
'agent_role': "test_agent", 'agent_role': "test_agent",
'save_time_ms': ANY 'save_time_ms': ANY
} }
crewai_event_bus._handlers.clear()

View File

@@ -20,6 +20,7 @@ def long_term_memory():
def test_long_term_memory_save_events(long_term_memory): def test_long_term_memory_save_events(long_term_memory):
events = defaultdict(list) events = defaultdict(list)
with crewai_event_bus.scoped_handlers():
@crewai_event_bus.on(MemorySaveStartedEvent) @crewai_event_bus.on(MemorySaveStartedEvent)
def on_save_started(source, event): def on_save_started(source, event):
events["MemorySaveStartedEvent"].append(event) events["MemorySaveStartedEvent"].append(event)
@@ -64,12 +65,11 @@ def test_long_term_memory_save_events(long_term_memory):
"save_time_ms": ANY, "save_time_ms": ANY,
} }
crewai_event_bus._handlers.clear()
def test_long_term_memory_search_events(long_term_memory): def test_long_term_memory_search_events(long_term_memory):
events = defaultdict(list) events = defaultdict(list)
with crewai_event_bus.scoped_handlers():
@crewai_event_bus.on(MemoryQueryStartedEvent) @crewai_event_bus.on(MemoryQueryStartedEvent)
def on_search_started(source, event): def on_search_started(source, event):
events["MemoryQueryStartedEvent"].append(event) events["MemoryQueryStartedEvent"].append(event)
@@ -113,7 +113,6 @@ def test_long_term_memory_search_events(long_term_memory):
'query_time_ms': ANY 'query_time_ms': ANY
} }
crewai_event_bus._handlers.clear()
def test_save_and_search(long_term_memory): def test_save_and_search(long_term_memory):
memory = LongTermMemoryItem( memory = LongTermMemoryItem(

View File

@@ -38,6 +38,7 @@ def short_term_memory():
def test_short_term_memory_search_events(short_term_memory): def test_short_term_memory_search_events(short_term_memory):
events = defaultdict(list) events = defaultdict(list)
with crewai_event_bus.scoped_handlers():
@crewai_event_bus.on(MemoryQueryStartedEvent) @crewai_event_bus.on(MemoryQueryStartedEvent)
def on_search_started(source, event): def on_search_started(source, event):
events["MemoryQueryStartedEvent"].append(event) events["MemoryQueryStartedEvent"].append(event)
@@ -81,12 +82,10 @@ def test_short_term_memory_search_events(short_term_memory):
'query_time_ms': ANY 'query_time_ms': ANY
} }
crewai_event_bus._handlers.clear()
def test_short_term_memory_save_events(short_term_memory): def test_short_term_memory_save_events(short_term_memory):
events = defaultdict(list) events = defaultdict(list)
with crewai_event_bus.scoped_handlers():
@crewai_event_bus.on(MemorySaveStartedEvent) @crewai_event_bus.on(MemorySaveStartedEvent)
def on_save_started(source, event): def on_save_started(source, event):
events["MemorySaveStartedEvent"].append(event) events["MemorySaveStartedEvent"].append(event)
@@ -128,8 +127,6 @@ def test_short_term_memory_save_events(short_term_memory):
'save_time_ms': ANY 'save_time_ms': ANY
} }
crewai_event_bus._handlers.clear()
def test_save_and_search(short_term_memory): def test_save_and_search(short_term_memory):
memory = ShortTermMemoryItem( memory = ShortTermMemoryItem(
data="""test value test value test value test value test value test value data="""test value test value test value test value test value test value