From 10edde100e535dd04a26856344d83baf72f85846 Mon Sep 17 00:00:00 2001 From: "devin-ai-integration[bot]" <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Mon, 14 Apr 2025 08:55:23 -0400 Subject: [PATCH] Fix: Use mem0_local_config instead of config in Memory.from_config (#2588) * fix: use mem0_local_config instead of config in Memory.from_config (#2587) Co-Authored-By: Joe Moura * refactor: consolidate tests as per PR feedback Co-Authored-By: Joe Moura --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Joe Moura --- src/crewai/memory/storage/mem0_storage.py | 2 +- tests/storage/test_mem0_storage.py | 10 ++++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/crewai/memory/storage/mem0_storage.py b/src/crewai/memory/storage/mem0_storage.py index ccf8cc810..835788727 100644 --- a/src/crewai/memory/storage/mem0_storage.py +++ b/src/crewai/memory/storage/mem0_storage.py @@ -48,7 +48,7 @@ class Mem0Storage(Storage): self.memory = MemoryClient(api_key=mem0_api_key) else: if mem0_local_config and len(mem0_local_config): - self.memory = Memory.from_config(config) + self.memory = Memory.from_config(mem0_local_config) else: self.memory = Memory() diff --git a/tests/storage/test_mem0_storage.py b/tests/storage/test_mem0_storage.py index f9e56739f..f0c62d480 100644 --- a/tests/storage/test_mem0_storage.py +++ b/tests/storage/test_mem0_storage.py @@ -29,7 +29,7 @@ def mem0_storage_with_mocked_config(mock_mem0_memory): """Fixture to create a Mem0Storage instance with mocked dependencies""" # Patch the Memory class to return our mock - with patch("mem0.memory.main.Memory.from_config", return_value=mock_mem0_memory): + with patch("mem0.memory.main.Memory.from_config", return_value=mock_mem0_memory) as mock_from_config: config = { "vector_store": { "provider": "mock_vector_store", @@ -66,13 +66,15 @@ def mem0_storage_with_mocked_config(mock_mem0_memory): ) mem0_storage = Mem0Storage(type="short_term", crew=crew) - return mem0_storage + return mem0_storage, mock_from_config, config def test_mem0_storage_initialization(mem0_storage_with_mocked_config, mock_mem0_memory): """Test that Mem0Storage initializes correctly with the mocked config""" - assert mem0_storage_with_mocked_config.memory_type == "short_term" - assert mem0_storage_with_mocked_config.memory is mock_mem0_memory + mem0_storage, mock_from_config, config = mem0_storage_with_mocked_config + assert mem0_storage.memory_type == "short_term" + assert mem0_storage.memory is mock_mem0_memory + mock_from_config.assert_called_once_with(config) @pytest.fixture