From 0af7e04cded56b71067dafbd1a230aa161224dba Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Mon, 20 Oct 2025 12:24:36 +0000 Subject: [PATCH] fix: address lint issues in streaming implementation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Remove whitespace from blank lines - Refactor try-except out of loop for better performance - Use list() instead of append in loop for better performance Co-Authored-By: João --- src/crewai/crew.py | 12 +++++------- tests/test_crew.py | 12 +++--------- 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/src/crewai/crew.py b/src/crewai/crew.py index 590b48155..8b033b59a 100644 --- a/src/crewai/crew.py +++ b/src/crewai/crew.py @@ -792,7 +792,7 @@ class Crew(FlowTrackable, BaseModel): def event_generator(): for event in crew.kickoff_stream(inputs={"topic": "AI"}): yield f"data: {json.dumps(event)}\\n\\n" - + return StreamingResponse( event_generator(), media_type="text/event-stream" @@ -868,15 +868,13 @@ class Crew(FlowTrackable, BaseModel): try: while not completion_event.is_set() or not event_queue.empty(): - try: - event = event_queue.get(timeout=0.1) + event = event_queue.get(timeout=0.1) if not event_queue.empty() else None + if event is not None: yield event - except queue.Empty: - continue - + if exception_holder["exception"]: raise exception_holder["exception"] - + finally: thread.join(timeout=1) diff --git a/tests/test_crew.py b/tests/test_crew.py index 92c47ad74..3e9c962c1 100644 --- a/tests/test_crew.py +++ b/tests/test_crew.py @@ -4757,9 +4757,7 @@ def test_crew_kickoff_stream(researcher): crew = Crew(agents=[researcher], tasks=[task]) - events = [] - for event in crew.kickoff_stream(): - events.append(event) + events = list(crew.kickoff_stream()) assert len(events) > 0 @@ -4784,9 +4782,7 @@ def test_crew_kickoff_stream_with_inputs(researcher): crew = Crew(agents=[researcher], tasks=[task]) - events = [] - for event in crew.kickoff_stream(inputs={"topic": "machine learning"}): - events.append(event) + events = list(crew.kickoff_stream(inputs={"topic": "machine learning"})) assert len(events) > 0 @@ -4806,9 +4802,7 @@ def test_crew_kickoff_stream_includes_llm_chunks(researcher): crew = Crew(agents=[researcher], tasks=[task]) - events = [] - for event in crew.kickoff_stream(): - events.append(event) + events = list(crew.kickoff_stream()) event_types = [event["type"] for event in events]