andre/crewAI
1
0
Fork 0
mirror of https://github.com/crewAIInc/crewAI.git synced 2026-01-11 09:08:31 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Enhance set_callbacks with improved type hints, error handling, and expanded test coverage

Browse Source 
Co-Authored-By: Joe Moura <joao@crewai.com>
This commit is contained in:
Devin AI
2025-04-03 09:44:06 +00:00
parent 4f5d18a2c9
commit 0a22cbc349
2 changed files with 125 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
src/crewai/llm.py
View File

@@ -956,23 +956,42 @@ class LLM(BaseLLM):
self.context_window_size = int(value * CONTEXT_WINDOW_USAGE_RATIO)
return self.context_window_size
def set_callbacks(self, callbacks: List[Any]):
def set_callbacks(self, callbacks: List[Any]) -> None:
"""
Attempt to keep a single set of callbacks in litellm by removing old
duplicates and adding new ones.
This method safely updates the litellm callback lists by:
1. Identifying the types of new callbacks
2. Filtering out existing callbacks of the same types
3. Setting the new callbacks
Args:
callbacks: List of callback objects to set in litellm
Returns:
None
Note:
Uses list comprehension to avoid "list.remove(x): x not in list" errors
that can occur with direct removal during iteration.
"""
with suppress_warnings():
callback_types = [type(callback) for callback in callbacks]
litellm.success_callback = [
cb for cb in litellm.success_callback if type(cb) not in callback_types
]
litellm._async_success_callback = [
cb for cb in litellm._async_success_callback if type(cb) not in callback_types
]
litellm.callbacks = callbacks
try:
with suppress_warnings():
callback_types = [type(callback) for callback in callbacks]
litellm.success_callback = [
cb for cb in litellm.success_callback if type(cb) not in callback_types
]
litellm._async_success_callback = [
cb for cb in litellm._async_success_callback if type(cb) not in callback_types
]
litellm.callbacks = callbacks
except Exception as e:
logging.error(f"Error setting callbacks: {str(e)}")
raise
def set_env_callbacks(self):
"""