mirror of
https://github.com/crewAIInc/crewAI.git
synced 2026-07-03 14:09:24 +00:00
Fix deployment page link id resolution (#6365)
This commit is contained in:
@@ -187,13 +187,13 @@ def test_deployment_page_url_prefers_nested_deployment_id_over_crew_uuid():
|
||||
)
|
||||
|
||||
|
||||
def test_deployment_page_url_falls_back_to_nested_uuid():
|
||||
def test_deployment_page_url_does_not_use_uuid_as_deployment_id():
|
||||
assert (
|
||||
deploy_main._deployment_page_url(
|
||||
"https://app.crewai.com/",
|
||||
{"deployment": {"uuid": "deployment-uuid"}},
|
||||
{"uuid": "crew-uuid", "deployment": {"uuid": "deployment-uuid"}},
|
||||
)
|
||||
== "https://app.crewai.com/crewai_plus/deployments/deployment-uuid"
|
||||
is None
|
||||
)
|
||||
|
||||
|
||||
@@ -353,6 +353,51 @@ class TestDeployCommand(unittest.TestCase):
|
||||
"https://app.crewai.com/crewai_plus/deployments/128687"
|
||||
)
|
||||
|
||||
def test_display_creation_success_resolves_deployment_page_id_from_status(self):
|
||||
status_response = MagicMock()
|
||||
status_response.is_success = True
|
||||
status_response.json.return_value = {
|
||||
"uuid": "new-uuid",
|
||||
"id": 128774,
|
||||
"status": "created",
|
||||
}
|
||||
self.mock_client.crew_status_by_uuid.return_value = status_response
|
||||
|
||||
with patch("sys.stdout", new=StringIO()) as fake_out:
|
||||
self.deploy_command._display_creation_success(
|
||||
{"uuid": "new-uuid", "status": "created"}
|
||||
)
|
||||
output = fake_out.getvalue()
|
||||
|
||||
self.assertIn("crewai deploy push --uuid new-uuid", output)
|
||||
self.assertIn(
|
||||
"https://app.crewai.com/crewai_plus/deployments/128774",
|
||||
output,
|
||||
)
|
||||
self.assertNotIn(
|
||||
"https://app.crewai.com/crewai_plus/deployments/new-uuid",
|
||||
output,
|
||||
)
|
||||
self.mock_client.crew_status_by_uuid.assert_called_once_with("new-uuid")
|
||||
self.mock_browser_open.assert_called_once_with(
|
||||
"https://app.crewai.com/crewai_plus/deployments/128774"
|
||||
)
|
||||
|
||||
def test_open_deployment_page_does_not_open_uuid_url_when_status_lookup_fails(
|
||||
self,
|
||||
):
|
||||
status_response = MagicMock()
|
||||
status_response.is_success = False
|
||||
self.mock_client.crew_status_by_uuid.return_value = status_response
|
||||
|
||||
with patch("sys.stdout", new=StringIO()) as fake_out:
|
||||
self.deploy_command._open_deployment_page({"uuid": "new-uuid"})
|
||||
output = fake_out.getvalue()
|
||||
|
||||
self.mock_client.crew_status_by_uuid.assert_called_once_with("new-uuid")
|
||||
self.mock_browser_open.assert_not_called()
|
||||
self.assertNotIn("deployments/new-uuid", output)
|
||||
|
||||
def test_display_logs(self):
|
||||
with patch("sys.stdout", new=StringIO()) as fake_out:
|
||||
self.deploy_command._display_logs(
|
||||
|
||||
Reference in New Issue
Block a user