From 035a90d937bfca5e3900377b970a288f4de2dbbc Mon Sep 17 00:00:00 2001
From: Rip&Tear <84775494+theCyberTech@users.noreply.github.com>
Date: Thu, 25 Jun 2026 09:49:07 +0800
Subject: [PATCH] Log secure settings fd close failures

---
 lib/crewai-core/src/crewai_core/settings.py | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/lib/crewai-core/src/crewai_core/settings.py b/lib/crewai-core/src/crewai_core/settings.py
index 5405cb977..967aa445c 100644
--- a/lib/crewai-core/src/crewai_core/settings.py
+++ b/lib/crewai-core/src/crewai_core/settings.py
@@ -61,8 +61,13 @@ def _write_secure_json(path: Path, data: dict[str, Any]) -> None:
         if fd_open:
             try:
                 os.close(fd)
-            except OSError:
-                pass
+            except OSError as close_error:
+                logger.debug(
+                    "Could not close temporary settings file descriptor for %s "
+                    "(best-effort cleanup): %s",
+                    tmp,
+                    close_error,
+                )
         if os.path.exists(tmp):
             os.unlink(tmp)
         raise