andre/crewAI
1
0
Fork 0
mirror of https://github.com/crewAIInc/crewAI.git synced 2026-01-21 13:58:15 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Enhance event handling for Crew, Task, and Event classes

Browse Source 
- Add crew name to failed event types (CrewKickoffFailedEvent, CrewTrainFailedEvent, CrewTestFailedEvent)
- Update Task events to remove redundant task and context attributes
- Refactor EventListener to use Logger for consistent event logging
- Add new event types for Crew train and test events
- Improve event bus event tracking in test cases
This commit is contained in:
Lorenze Jay
2025-02-13 12:01:18 -08:00
parent 62a20426a5
commit 00a98cd5c9
9 changed files with 184 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/crewai/crew.py
View File

@@ -560,7 +560,12 @@ class Crew(BaseModel):
),
)
except Exception as e:
event_bus.emit(self, CrewTrainFailedEvent(error=str(e)))
event_bus.emit(
self,
CrewTrainFailedEvent(
error=str(e), crew_name=self.name or "crew"
),
)
self._logger.log("error", f"Training failed: {e}", color="red")
CrewTrainingHandler(TRAINING_DATA_FILE).clear()
CrewTrainingHandler(filename).clear()
@@ -630,7 +635,12 @@ class Crew(BaseModel):
self.usage_metrics.add_usage_metrics(metric)
return result
except Exception as e:
event_bus.emit(self, CrewKickoffFailedEvent(error=str(e)))
event_bus.emit(
self,
CrewKickoffFailedEvent(
error=str(e), crew_name=self.name or "crew"
),
)
raise
def kickoff_for_each(self, inputs: List[Dict[str, Any]]) -> List[CrewOutput]:
@@ -1224,7 +1234,12 @@ class Crew(BaseModel):
),
)
except Exception as e:
event_bus.emit(self, CrewTestFailedEvent(error=str(e)))
event_bus.emit(
self,
CrewTestFailedEvent(
error=str(e), crew_name=self.name or "crew"
),
)
raise
def __repr__(self):

4
src/crewai/task.py
View File

@@ -371,7 +371,7 @@ class Task(BaseModel):
tools = tools or self.tools or []
self.processed_by_agents.add(agent.role)
event_bus.emit(self, TaskStartedEvent(task=self))
event_bus.emit(self, TaskStartedEvent(context=context))
result = agent.execute_task(
task=self,
context=context,
@@ -451,7 +451,7 @@ class Task(BaseModel):
else result
)
self._save_file(content)
event_bus.emit(self, TaskCompletedEvent(task=self, output=task_output))
event_bus.emit(self, TaskCompletedEvent(output=task_output))
return task_output
except Exception as e:
self.end_time = datetime.datetime.now()

6
src/crewai/utilities/events/__init__.py
View File

@@ -2,6 +2,12 @@ from .crew_events import (
CrewKickoffStartedEvent,
CrewKickoffCompletedEvent,
CrewKickoffFailedEvent,
CrewTrainStartedEvent,
CrewTrainCompletedEvent,
CrewTrainFailedEvent,
CrewTestStartedEvent,
CrewTestCompletedEvent,
CrewTestFailedEvent,
)
from .agent_events import (
AgentExecutionStartedEvent,

1
src/crewai/utilities/events/base_event_listener.py
View File

@@ -1,4 +1,5 @@
from abc import ABC, abstractmethod
from logging import Logger
from crewai.utilities.events.event_bus import EventBus, event_bus

4
src/crewai/utilities/events/crew_events.py
View File

@@ -38,6 +38,7 @@ class CrewKickoffFailedEvent(CrewEvent):
"""Event emitted when a crew fails to complete execution"""
error: str
crew_name: Optional[str]
type: str = "crew_kickoff_failed"
@@ -64,6 +65,7 @@ class CrewTrainFailedEvent(CrewEvent):
"""Event emitted when a crew fails to complete training"""
error: str
crew_name: Optional[str]
type: str = "crew_train_failed"
@@ -88,4 +90,6 @@ class CrewTestFailedEvent(CrewEvent):
"""Event emitted when a crew fails to complete testing"""
error: str
crew_name: Optional[str]
type: str = "crew_test_failed"

127
src/crewai/utilities/events/event_listener.py
View File

@@ -1,15 +1,22 @@
from re import S
from pydantic import PrivateAttr
from crewai.telemetry.telemetry import Telemetry
from crewai.utilities import Logger
from crewai.utilities.evaluators.task_evaluator import TaskEvaluator
from crewai.utilities.events.base_event_listener import BaseEventListener
from .agent_events import AgentExecutionCompletedEvent, AgentExecutionStartedEvent
from .crew_events import (
CrewKickoffCompletedEvent,
CrewKickoffFailedEvent,
CrewKickoffStartedEvent,
CrewTestCompletedEvent,
CrewTestFailedEvent,
CrewTestStartedEvent,
CrewTrainCompletedEvent,
CrewTrainFailedEvent,
CrewTrainStartedEvent,
)
from .flow_events import (
FlowFinishedEvent,
@@ -22,23 +29,42 @@ from .task_events import TaskCompletedEvent, TaskStartedEvent
class EventListener(BaseEventListener):
_telemetry: Telemetry = PrivateAttr(default_factory=lambda: Telemetry())
logger = Logger(verbose=True)
color = "bold_blue"
def __init__(self):
super().__init__()
self._telemetry = Telemetry()
self._telemetry.set_tracer()
# Crew Events: kickoff, test, train
def setup_listeners(self, event_bus):
@event_bus.on(CrewKickoffStartedEvent)
def on_crew_started(source, event: CrewKickoffStartedEvent):
print(f"🚀 Crew '{event.crew_name}' started", event.timestamp)
print("event.inputs", event.inputs)
self.logger.log(
f"🚀 Crew '{event.crew_name}' started",
event.timestamp,
color=self.color,
)
self._telemetry.crew_execution_span(source, event.inputs)
@event_bus.on(CrewKickoffCompletedEvent)
def on_crew_completed(source, event: CrewKickoffCompletedEvent):
final_string_output = event.output.raw
self._telemetry.end_crew(source, final_string_output)
self.logger.log(
f"✅ Crew '{event.crew_name}' completed",
event.timestamp,
color=self.color,
)
@event_bus.on(CrewKickoffFailedEvent)
def on_crew_failed(source, event: CrewKickoffFailedEvent):
self.logger.log(
f"❌ Crew '{event.crew_name}' failed",
event.timestamp,
color=self.color,
)
@event_bus.on(CrewTestStartedEvent)
def on_crew_test_started(source, event: CrewTestStartedEvent):
@@ -49,50 +75,109 @@ class EventListener(BaseEventListener):
event.inputs,
event.openai_model_name,
)
print(f"🚀 Crew '{event.crew_name}' started test")
self.logger.log(
f"🚀 Crew '{event.crew_name}' started test",
event.timestamp,
color=self.color,
)
@event_bus.on(CrewTestCompletedEvent)
def on_crew_test_completed(source, event: CrewTestCompletedEvent):
print(f"👍 Crew '{event.crew_name}' completed test")
self.logger.log(
f"✅ Crew '{event.crew_name}' completed test",
event.timestamp,
color=self.color,
)
@event_bus.on(TaskStartedEvent)
def on_task_started(source, event: TaskStartedEvent):
print(f"📋 Task started: {event.task.description}")
@event_bus.on(CrewTestFailedEvent)
def on_crew_test_failed(source, event: CrewTestFailedEvent):
self.logger.log(
f"❌ Crew '{event.crew_name}' failed test",
event.timestamp,
color=self.color,
)
@event_bus.on(CrewTrainStartedEvent)
def on_crew_train_started(source, event: CrewTrainStartedEvent):
self.logger.log(
f"📋 Crew '{event.crew_name}' started train",
event.timestamp,
color=self.color,
)
@event_bus.on(CrewTrainCompletedEvent)
def on_crew_train_completed(source, event: CrewTrainCompletedEvent):
self.logger.log(
f"✅ Crew '{event.crew_name}' completed train",
event.timestamp,
color=self.color,
)
@event_bus.on(CrewTrainFailedEvent)
def on_crew_train_failed(source, event: CrewTrainFailedEvent):
self.logger.log(
f"❌ Crew '{event.crew_name}' failed train",
event.timestamp,
color=self.color,
)
@event_bus.on(TaskCompletedEvent)
def on_task_completed(source, event: TaskCompletedEvent):
print(f" Output: {event.output}")
result = TaskEvaluator(event.task.agent).evaluate(event.task, event.output)
print(f" Evaluation: {result.quality}")
if result.quality > 5:
print(f" ✅ Passed: {result.suggestions}")
else:
print(f" ❌ Failed: {result.suggestions}")
self._telemetry.task_ended(source._execution_span, source, source)
self.logger.log(
f"📋 Task completed: {source.description}",
event.timestamp,
color=self.color,
)
@event_bus.on(AgentExecutionStartedEvent)
def on_agent_execution_started(source, event: AgentExecutionStartedEvent):
print(f"🤖 Agent '{event.agent.role}' started task")
self.logger.log(
f"🤖 Agent '{event.agent.role}' started task",
event.timestamp,
color=self.color,
)
@event_bus.on(AgentExecutionCompletedEvent)
def on_agent_execution_completed(source, event: AgentExecutionCompletedEvent):
print(f"👍 Agent '{event.agent.role}' completed task")
print(f" Output: {event.output}")
self.logger.log(
f"👍 Agent '{event.agent.role}' completed task",
event.timestamp,
color=self.color,
)
# Flow Events
@event_bus.on(FlowStartedEvent)
def on_flow_started(source, event: FlowStartedEvent):
print(f"🤖 Flow Started: '{event.flow_name}'")
self.logger.log(
f"🤖 Flow Started: '{event.flow_name}'",
event.timestamp,
color=self.color,
)
@event_bus.on(FlowFinishedEvent)
def on_flow_finished(source, event: FlowFinishedEvent):
print(f"👍 Flow Finished: '{event.flow_name}'")
self.logger.log(
f"👍 Flow Finished: '{event.flow_name}'",
event.timestamp,
color=self.color,
)
@event_bus.on(MethodExecutionStartedEvent)
def on_method_execution_started(source, event: MethodExecutionStartedEvent):
print(f"🤖 Flow Method Started: '{event.method_name}'")
self.logger.log(
f"🤖 Flow Method Started: '{event.method_name}'",
event.timestamp,
color=self.color,
)
@event_bus.on(MethodExecutionFinishedEvent)
def on_method_execution_finished(source, event: MethodExecutionFinishedEvent):
print(f"👍 Flow Method Finished: '{event.method_name}'")
self.logger.log(
f"👍 Flow Method Finished: '{event.method_name}'",
event.timestamp,
color=self.color,
)
event_listener = EventListener()

7
src/crewai/utilities/events/task_events.py
View File

@@ -1,4 +1,4 @@
from typing import Any
from typing import Any, Optional
from crewai.utilities.events.crew_events import CrewEvent
@@ -6,16 +6,15 @@ from crewai.utilities.events.crew_events import CrewEvent
class TaskStartedEvent(CrewEvent):
"""Event emitted when a task starts"""
task: Any
type: str = "task_started"
context: Optional[str]
model_config = {"arbitrary_types_allowed": True}
class TaskCompletedEvent(CrewEvent):
"""Event emitted when a task completes"""
task: Any
output: Any
type: str = "task_completed"